Repository navigation
fix: clear inherited ODF backgrounds and borders - #1089
Merged
Merged
Conversation
andiwand
force-pushed
the
review/70-odf-chart-geometry
branch
from
October 5, 2026 18:57
0842929 to
3d65efe
Compare
A transparent colour or a none border in the resolved style changed the public contract, so a removed highlight read back as a colour and the HTML gained no-op declarations. Clear the inherited value while the style resolves, and keep nullopt for no background and no border. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/71-odf-style-clearing
branch
from
October 5, 2026 19:17
bb50cc0 to
ad33c72
Compare
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
The library already uses explicit object parameters, and every CI compiler builds them, so the recursive test lambdas keep `this auto` instead of passing themselves. A removed ODF highlight reads back as nullopt since #1089, so the test expects that again and passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
* test: strengthen round trips and consolidate HTML assertions * test: keep deducing-this lambdas and the cleared highlight contract The library already uses explicit object parameters, and every CI compiler builds them, so the recursive test lambdas keep `this auto` instead of passing themselves. A removed ODF highlight reads back as nullopt since #1089, so the test expects that again and passes. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
…arts A stated ODF transparent reads as no colour and clears an inherited background since #1089, so it is not an alpha-zero colour. A codespace range reads a whole code of its width and checks it against its bounds, not each byte. A save writes every part an edit loaded, not only chart parts. The changed Markdown paragraphs are wrapped at 80 columns again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
* docs: align editing and PDF design notes with implementation * docs: correct transparent backgrounds, codespace matching and saved parts A stated ODF transparent reads as no colour and clears an inherited background since #1089, so it is not an alpha-zero colour. A codespace range reads a whole code of its width and checks it against its bounds, not each byte. A save writes every part an edit loaded, not only chart parts. The changed Markdown paragraphs are wrapped at 80 columns again. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Explicit ODF transparency and
noneborders now override inherited paint instead of being treated as absent properties. Clearing a fill inherited from a named cell style therefore works both immediately and after save/reopen. The resolved style still reports no background and no border as nothing, so a removed highlight reads back empty.The existing fill-clearing test covers both automatic and named styles through save/reopen. One additional regression covers inherited cell/text backgrounds and a border shorthand with a side override. All 212 ODF tests pass.