Repository navigation
fix(jni): preserve Unicode across string and exception boundaries - #1098
Merged
Merged
Conversation
andiwand
force-pushed
the
review/79-python-test-concision
branch
from
October 5, 2026 20:28
3fbe25b to
0e29e22
Compare
andiwand
force-pushed
the
review/80-jni-unicode
branch
from
October 5, 2026 20:30
4f8c6ab to
a77a232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Java exception messages now preserve supplementary Unicode characters instead of passing regular UTF-8 to JNI's modified-UTF-8 API. String conversion rejects unpaired Java surrogates, replaces invalid native UTF-8 scalar values, releases pinned strings on failure, and checks Java string/byte-array length conversions. Exception translation preserves an already pending Java exception and cannot unwind through JNI.
Validation: all 79 JNI tests pass. Extended existing logger and HTML-service checks; added one malformed-surrogate test that fails before the fix. A temporary native conversion harness passes 10 malformed/boundary UTF-8 cases. Clang-tidy reports the existing
portability-template-virtual-member-functionwarning inexceptions.hpp.