Repository navigation
fix(jni): check integer ranges at binding boundaries - #1099
Merged
Merged
Conversation
andiwand
force-pushed
the
review/80-jni-unicode
branch
from
October 5, 2026 20:30
4f8c6ab to
a77a232
Compare
andiwand
force-pushed
the
review/81-jni-integer-bounds
branch
from
October 5, 2026 20:32
308873c to
afc3a6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
JNI now checks integer ranges when converting rendering limits, spreadsheet coordinates/counts, color channels, CSV delimiters and table positions. Negative Java values no longer become huge unsigned limits, and values outside Java's signed range no longer return wrapped coordinates. A shared conversion helper keeps those checks consistent.
Validation: all 81 JNI tests pass. Three targeted checks fail on the parent revision. Existing style, delimiter and position tests cover further boundaries; two new tests cover configuration and sheet inputs. Clang-tidy still reports existing public-header diagnostics and an existing redundant move in
wrap_element.