Skip to content

fix(bindings): validate native packages and Java requirements - #1103

Merged
andiwand merged 1 commit into
mainfrom
review/85-android-native-packaging
Oct 5, 2026
Merged

andiwand merged 1 commit into
mainfrom
review/85-android-native-packaging

Conversation

@andiwand

@andiwand andiwand commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

🤖 Generated with Claude Code

Android's checkNative now requires nonempty libodr_jni.so and libc++_shared.so files in every supplied ABI directory. Previously an empty directory passed, allowing a broken AAR to reach consumers. Prebuilt single-ABI trees remain supported for emulator builds. JNI jar configuration also requires JDK 17, matching --release 17.

Validation: the real Gradle task rejects an empty ABI directory, a missing runtime and an empty runtime, and accepts a complete nonempty pair. CMake configures successfully with the installed JDK. This checks package contents, not ELF validity or an Android runtime.

@andiwand
andiwand force-pushed the review/84-jni-test-concision branch from 2c45eea to 702b59f Compare October 5, 2026 20:45
Base automatically changed from review/84-jni-test-concision to main October 5, 2026 20:49
@andiwand
andiwand force-pushed the review/85-android-native-packaging branch from 55a9d20 to 70fe43e Compare October 5, 2026 20:49
@andiwand
andiwand merged commit 57e69ae into main Oct 5, 2026
23 checks passed
@andiwand
andiwand deleted the review/85-android-native-packaging branch October 5, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant