Repository navigation
fix(bindings): propagate binary file read failures - #1104
Merged
Merged
Conversation
andiwand
force-pushed
the
review/85-android-native-packaging
branch
from
October 5, 2026 20:49
55a9d20 to
70fe43e
Compare
The corrupt archive has one user, so it lives in that test. The Apple sources no longer read a std::istream. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/86-binding-file-reads
branch
from
October 5, 2026 20:58
94f43af to
2b6d955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Python and Java image/font reads, and Apple file/image/font reads, now use the existing checked
File::pipeAPI. Direct stream-buffer insertion could swallow a ZIP checksum failure and return truncated bytes as success: the regression input previously returned 999,424 of 1,000,008 bytes without an error.Validation: all 97 Python and 78 JNI tests pass. One Python regression covers the corrupt archive entry. A temporary Objective-C++ harness reproduces the Apple failure before the change and receives an NSError after it; both changed Apple implementation files compile to native objects. The full Swift/iOS suite was not run for this layer.