Repository navigation
fix(apple): contain measurement construction failures - #1105
Merged
Merged
Conversation
andiwand
force-pushed
the
review/86-binding-file-reads
branch
from
October 5, 2026 20:58
94f43af to
2b6d955
Compare
It stores a magnitude and a unit and cannot fail, so it keeps its nonnull Swift signature. Only Measure(string:) parses and becomes failable. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/87-apple-measures
branch
from
October 5, 2026 21:02
fac4214 to
916a914
Compare
andiwand
changed the title
A signature change in a binding wrapper is not breaking. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Invalid Apple
Measure(string:)input lets a C++ exception escape into Swift. GuardMeasure(string:)and expose failure asnil; the changelog calls out its now-failable Swift signature.Measure(magnitude:unit:)cannot fail and keeps its signature.One Swift test covers valid and invalid construction. All 58 macOS Swift tests pass against the locally built framework; an Objective-C++ reproducer catches the escaping exception on the parent. Local dependency deployment targets do not validate macOS 12 or iOS compatibility.