Repository navigation
fix(apple): validate CSV delimiters and root interfaces - #1106
Merged
Merged
Conversation
andiwand
force-pushed
the
review/87-apple-measures
branch
from
October 5, 2026 21:02
fac4214 to
916a914
Compare
An empty separator or quote meant detect before, as the removed comment said; a cleared text field still does. Only a string of more than one UTF-8 byte fails decoding. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/88-apple-decode-boundaries
branch
from
October 5, 2026 21:08
e9ab47a to
9e9803b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Apple CSV options silently kept only the first UTF-16 code unit, and CSV roots were wrapped as
TextRootdespite lacking that interface. Validate both delimiters as one UTF-8 byte, with an empty string still meaning unset, and choose the root wrapper from the native interface.Nine regression assertions fail on the parent. All 59 macOS Swift tests pass after the fix; one new delimiter test complements the existing CSV decode test.