Repository navigation
fix(wasm): check integer bounds before conversion - #1107
Merged
Merged
Conversation
andiwand
force-pushed
the
review/88-apple-decode-boundaries
branch
from
October 5, 2026 21:08
e9ab47a to
9e9803b
Compare
A signed 64-bit target took any double down to -2^63, where doubles no longer hold every integer. Both bounds now stop at 2^53 - 1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/89-wasm-integer-bounds
branch
from
October 5, 2026 21:14
e91b2a5 to
d04c032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
WebAssembly truncated fractional element IDs and sheet coordinates, and converted nonfinite or oversized inputs to integers without checking. A shared checked conversion now validates IDs, coordinates, rendering limits and view indices before use. Style-operation argument construction is inside the exception guard too.
Three regression cases fail on the parent; all 66 Node/WebAssembly tests pass after an Emscripten build. The existing unknown-ID test now also checks fractional and nonfinite inputs; two additional cases cover config and coordinates.