Repository navigation
fix(wasm): reject reentrant native calls - #1108
Merged
Merged
Conversation
andiwand
force-pushed
the
review/89-wasm-integer-bounds
branch
from
October 5, 2026 21:14
e91b2a5 to
d04c032
Compare
andiwand
force-pushed
the
review/90-wasm-reentrancy
branch
from
October 5, 2026 21:32
ebf00b3 to
4baecb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
A style object's
toJSON()could close its document while native code retained a reference to the session, causing a WebAssembly runtime trap. Guard active calls against reentry so callbacks cannot close or mutate that state until the operation finishes.All 67 Node/WebAssembly tests pass. One regression covers both close paths during serialization and recovery after a JavaScript exception. A parent reproducer reports
RuntimeError: null function or function signature mismatch.