Repository navigation
refactor: make reader invariants and fallbacks explicit - #1142
Merged
Merged
Conversation
andiwand
force-pushed
the
review/123-formula-analysis
branch
from
October 6, 2026 13:15
0fcf423 to
034c1cb
Compare
The comments at the OOXML relationship and number-format fallbacks said why the code continues. The rewrite only repeated the continue, so the original reasons stand above it again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/124-explicit-reader-invariants
branch
from
October 6, 2026 13:19
717f6ba to
c60c215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Pass validated Type3 data into the glyph renderer, keep CFB traversal checks at the loop boundary, and give fixed XML attribute names null-terminated types. Make intentional unsupported-operation fallbacks explicit and remove unnecessary copies and an unused forward declaration.
Validation: targeted document, spreadsheet, container, PNG and PDF extractor tests pass; changed implementation files pass LLVM 22 clang-tidy with the unrelated inheritance checks excluded. Existing coverage is reused.