Repository navigation
test: require meaningful corpus and embedded-font checks - #1155
Merged
Merged
Conversation
andiwand
force-pushed
the
review/136-pdf-file-indices
branch
from
October 6, 2026 18:04
98cdcc8 to
e9a40f9
Compare
The rewrite dropped the comments that say why the checks look the way they do: why one page is enough, why detection may go by name, why the actual file type decides for an encrypted OOXML package, and why a plain text file is checked apart. They stand again, and the upper-bound note now says that one file of a type has to pass. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/137-corpus-checks
branch
from
October 6, 2026 18:09
eec6133 to
1a56bc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Corpus checks could pass after examining no usable files or answers. Capability checks now try later candidates when opening or rendering fails, require a successful check when candidates exist, and explicitly skip when the corpus is unavailable. Formula comparisons skip empty corpora and require at least one evaluated result.
The font checker used the start of the whole @font-face match instead of its captured body, counting declared fonts again as orphan embeddings. Correct the offset and fail when no HTML files were found.
Validation: the two font regressions fail on the parent and pass with the fix; all seven script tests pass. Both capability tests and the formula corpus pass, comparing 14,970 of 15,160 formulas with no mismatches. The corrected checker reports 7 distinct fonts and 17 embeddings for the generated style-various PDF output, with zero OTS rejections. No additional C++ test suites were added.