Repository navigation
fix: preserve PDF object precedence during recovery - #1156
Merged
Merged
Conversation
andiwand
force-pushed
the
review/137-corpus-checks
branch
from
October 6, 2026 18:09
eec6133 to
1a56bc6
Compare
The rewrite dropped the comments that say why the candidates are copied before indexing, which definition of an id recovery keeps, and that a direct definition beats a compressed copy. They stand again, adapted to the new order: latest object stream first, and the last definition of an id wins whatever its generation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/138-pdf-recovery-precedence
branch
from
October 6, 2026 18:19
2f50fb5 to
16e474c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
PDF recovery kept older generations beside the last direct definition and indexed compressed copies in object-number order, allowing an older object stream to win. Recovery now replaces direct definitions by object ID, checks that same ID before adding compressed members, and scans candidate object streams from the latest file position first.
Direct definitions retain precedence over compressed copies; the module guide makes that recovery policy explicit.
Validation: three parent assertions fail across the extended recovery tests; 65 parser, cross-reference, writer and annotation tests pass, including the existing broken-file fixture. LLVM 22 clang-tidy passes for both implementation files.