Skip to content

fix(build): preserve developer script paths and failures - #1160

Merged
andiwand merged 2 commits into
mainfrom
review/142-development-scripts
Oct 6, 2026
Merged

andiwand merged 2 commits into
mainfrom
review/142-development-scripts

Conversation

@andiwand

@andiwand andiwand commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

🤖 Generated with Claude Code

Generated Conan environment values were sourced without quoting, and VS Code task inputs were interpolated into shell commands. Paths containing spaces, quotes or shell characters could break execution. Setup continued after failures, and installing hooks from a worktree wrote them into an unused private Git directory.

Quote generated values and validate variable names, pass task inputs as process arguments, and share a small profiling wrapper that preserves earlier traces. Setup/Conan scripts stop on the first failure. The hook manager installs into the common Git directory and traverses hook paths without word splitting.

Validation: all ten script tests pass. Parent regressions expose environment corruption, continued setup calls and missing shared hooks. A real temporary worktree verifies that the installed hook rejects a commit; a mocked profiler verifies literal argument forwarding. Bash syntax and JSON checks pass.

The quoting is compatible with CodeLLDB's dotenv reader and its single-quote parsing.

@andiwand
andiwand force-pushed the review/141-jbig2-bounds branch from cb86575 to b03c16a Compare October 6, 2026 18:41
Base automatically changed from review/141-jbig2-bounds to main October 6, 2026 18:45
andiwand and others added 2 commits October 6, 2026 20:45
The switch to process tasks also spread every single-item array over
three lines. Arrays that fit on one line stand on one line again, as in
the rest of the file, so the diff shows only the real change.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
@andiwand
andiwand force-pushed the review/142-development-scripts branch from 0047ac2 to 80c5a8f Compare October 6, 2026 18:46
@andiwand
andiwand merged commit 2b3c39a into main Oct 6, 2026
21 of 23 checks passed
@andiwand
andiwand deleted the review/142-development-scripts branch October 6, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant