Repository navigation
fix(build): resume interrupted test-data checkouts - #1165
Merged
Merged
Conversation
andiwand
force-pushed
the
review/146-conan-package-metadata
branch
from
October 6, 2026 19:06
9b6268d to
46aeaff
Compare
…ript The shortened header lost how to reach the two private repositories, why configure never moves an existing checkout, why the policy call only runs in script mode and why .git may be a file. They stand again in brief. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/147-test-data-recovery
branch
from
October 6, 2026 19:07
24c06b8 to
b80cf68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
A failed initial test-data fetch left a repository without HEAD, causing every subsequent setup attempt to fail. Resume these incomplete checkouts, including missing origin configuration, while continuing to leave existing revisions alone unless explicitly updated. Dirty and untracked files block checkout changes.
Share the fetch/checkout path and Git error handling. Replace COMMAND_ERROR_IS_FATAL (introduced in CMake 3.19) with explicit result checks compatible with this script's declared 3.15 minimum. Move the brief storage rationale to AGENTS.md and shorten the script comments, keeping the access note for the private repositories.
Validation: the retry regression fails on the parent. All 15 script tests pass; the two new local-Git tests cover interrupted setup, revision drift, explicit updates and preservation of tracked/untracked work. Tests use temporary paths with spaces and no network. CMake 3.15 itself was not available for runtime testing.