Repository navigation
fix(pdf): honor image sample depths and JPX decode rules - #1166
Merged
Merged
Conversation
andiwand
force-pushed
the
review/147-test-data-recovery
branch
from
October 6, 2026 19:07
24c06b8 to
b80cf68
Compare
andiwand
force-pushed
the
review/148-pdf-image-sampling
branch
from
October 6, 2026 19:14
cf34d88 to
71ca5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
JPEG 2000 images incorrectly applied a PDF Decode array, which can invert their colors. Ignore it as ISO 32000-1 Table 89 requires for ordinary JPX images. Share raster bit-depth validation, accepting only 1/2/4/8/16 and requiring one-bit stencil masks. Shorten the image API comments.
Validation: extend two existing tests, both failing on the parent, without adding test cases or duplicating codec fixtures. All 180 targeted tests and 50 PDF corpus HTML-generation checks pass. clang-tidy, Android/WebAssembly/iOS object builds, and the library plus four CLI analysis build pass. The corpus check does not compare rendered pixels.