Repository navigation
fix(html): preserve ink stroke pointer ownership and endpoint - #1171
Merged
Merged
Conversation
andiwand
force-pushed
the
review/152-detection-documentation
branch
from
October 6, 2026 19:30
67c6ebf to
941670a
Compare
The guard ignored every pointerdown while a stroke was active. When the stroke's pointerup was lost, the next press of the same pointer then continued the old stroke until some later pointerup. Only another pointer is ignored now; the same one going down again keeps the stroke so far and starts a new one, as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/153-annotation-pointer-ownership
branch
from
October 6, 2026 19:32
896254a to
febe1d8
Compare
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
Both output repositories carry the pdf-annotation.js from #1171 and #1173. A full run on 078390a matched every reference page byte for byte; only that script changed. #1178, merged since, changes how a file copy is written, not its bytes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
A second pointer could replace an active PDF ink stroke, leaving its first stroke incomplete. Pointer-up coordinates were also omitted, shortening strokes whose final position differed from the last move event. Keep the active pointer until it ends and process the final pointer-up sample. The same pointer going down again, after a lost pointer-up, keeps the stroke so far and starts a new one. Cancellation retains the last real sample.
Extend the existing ink browser scenario with competing-pointer and final-position assertions, plus a cancellation check. Both regressions fail on the parent; all 82 annotation browser checks pass after the fix. JavaScript syntax and the library build with regenerated frontend assets pass.