Repository navigation
Fix Zarr fill-value masking options for DataTree reads - #11663
anshurajbisoyi98-ctrl wants to merge 22 commits into
Conversation
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
|
The two failing checks appear to report the same six PyDAP network-test timeouts: test-py314 (flaky) and its aggregated Test Results check. These tests access test.opendap.org, which was also unreachable during investigation. The other 13 test jobs passed, and all 12 Zarr masking regression cases pass locally. |
Restore NamedArray masked-array handling and the pydap online tests to main: main already passes mypy without the NamedArray edits, and the pydap skips were only a workaround for a transient test.opendap.org 403.
|
The two remaining failures are |
Removed skip marker from TestPyDAPDatatreeIO due to 403 error.
The merge of main dropped the whats-new entries of pydata#11736 and pydata#11722. Combine this PR's entry with the one of pydata#11748, which fixed the same option for open_dataset, and mention all openers in the user guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
headtr1ck
left a comment
There was a problem hiding this comment.
I took the liberty to fix up the failed what's -new merge.
Looking good!
Description
Fixes an issue where
use_zarr_fill_value_as_maskwas not accepted when reading Zarr data through the DataTree and group-opening APIs.The option already controls fill-value masking in the Zarr store, so I forwarded it through
open_datatree()→open_groups_as_dict()→ZarrStore.open_store(). This lets DataTree reads reuse the existing masking behaviour without adding a second implementation. The chosen setting now applies consistently to the root and child groups, and the format-dependent defaults are unchanged when no setting is passed or it is set toNone.Cause: The Zarr DataTree and group-opening methods did not accept or forward
use_zarr_fill_value_as_mask.Tests: I added 12 regression cases covering both opening APIs, Zarr formats 2 and 3,
True/False/None, and root and child groups. All 12 failed before the fix and passed afterward.Additional change: A separate commit fixes existing NamedArray masked-array typing errors and adds three unmasked-array test cases.
Docs: Updated the I/O guide and the release notes.
Validation:
Not verified: full-project tests, other platforms, and remote CI.
Checklist
use_zarr_fill_value_as_maskinopen_datatreefor Zarr Stores #11361whats-new.rstAI Disclosure
I have tested any AI-generated content in my PR.
I take responsibility for any AI-generated content in my PR.
Tools: Codex (used for investigation, implementation, tests, verification, documentation, and wording edits to this description).
Prompt summary: Address add
use_zarr_fill_value_as_maskinopen_datatreefor Zarr Stores #11361 using established repository patterns, add regression tests, verify the changes locally, and fix the remaining masked-array typing errors before submission.