Repository navigation
Pass use_zarr_fill_value_as_mask through open_dataset - #11748
Merged
Merged
Conversation
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Co-authored-by: Claude <noreply@anthropic.com>
vsaraikin
force-pushed
the
zarr-fill-value-mask
branch
from
October 16, 2026 14:33
f55a3d8 to
eacf350
Compare
github-actions
Bot
added
topic-backends
topic-zarr
headtr1ck
added a commit
to anshurajbisoyi98-ctrl/xarray
that referenced
this pull request
Oct 17, 2026
The merge of main dropped the whats-new entries of pydata#11736 and pydata#11722. Combine this PR's entry with the one of pydata#11748, which fixed the same option for open_dataset, and mention all openers in the user guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ZarrBackendEntrypoint.open_dataset passed use_zarr_fill_value_as_mask=None to ZarrStore.open_group instead of the user's value, so open_dataset/open_zarr always fell back to the per-format default. With zarr v3 there was no way to mask the zarr fill_value. test_zarr_fill_value_setting passed False, which was ignored, so I dropped it to keep the test checking the same thing. The second part of the issue was fixed in #11345, and #11663 does the same for open_datatree.
Checklist
use_zarr_fill_value_as_mask=Trueis ignored inopen_zarr#10269whats-new.rstAI Disclosure