Repository navigation
Arm backend: Relax SymbolicShapeSupport-checks - #22834
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22834
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 9afbe40 with merge base 5cdcc02 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@pytorchbot rerun -f |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
|
@pytorchbot rebase -b release/1.5 |
JacobSzwejbka
force-pushed
the
cherry-pick-22826-by-pytorch_bot_bot_
branch
from
September 17, 2026 19:22
4ff55ad to
cf3ee06
Compare
Allow TOSA support checks to distinguish between symbolic tensor metadata and symbolic shape materialization. Without the TOSA shape extension, symbolic tensor input/output shapes can still be accepted for ops whose lowering does not need materialized shape values. Reject symbolic SymInt arguments and the known shape- dependent edge cases instead. For targets that require fully resolved tensor shapes, add a separate partitioner-level check that rejects nodes with unresolved tensor input or output shapes. cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell @rascani Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> (cherry picked from commit 1498f7a)
JacobSzwejbka
force-pushed
the
cherry-pick-22826-by-pytorch_bot_bot_
branch
from
September 17, 2026 19:43
cf3ee06 to
9afbe40
Compare
rascani
approved these changes
Sep 17, 2026
Collaborator
|
Thanks 🙏 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow TOSA support checks to distinguish between symbolic tensor metadata and symbolic shape materialization.
Without the TOSA shape extension, symbolic tensor input/output shapes can still be accepted for ops whose lowering does not need materialized shape values. Reject symbolic SymInt arguments and the known shape- dependent edge cases instead.
For targets that require fully resolved tensor shapes, add a separate partitioner-level check that rejects nodes with unresolved tensor input or output shapes.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani