Skip to content

Include missing dependency in package.xml - #235

Merged
ahcorde merged 1 commit into
rollingfrom
ahcorde/rolling/missing_dependency
Oct 6, 2026
Merged

Include missing dependency in package.xml#235
ahcorde merged 1 commit into
rollingfrom
ahcorde/rolling/missing_dependency

Conversation

@ahcorde

@ahcorde ahcorde commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Include missing dependency

Claude Opus 4.8

@ahcorde
Include missing dependency in package.xml
4d7b671 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Sep 17, 2026
Merged
@ahcorde

ahcorde commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: ros2/common_interfaces#342, ros/ros_tutorials#206, #235, ros/pluginlib#310, ros/robot_state_publisher#255, ros/resource_retriever#127, ros-perception/laser_geometry#121, ros-perception/point_cloud_transport#194, ros-visualization/interactive_markers#129
Gist: https://gist.githubusercontent.com/ahcorde/164ff7a264dea3e74dc5733db3ba700b/raw/54aa40171dcdd29fd09d3f757086921a6ec9a175/ros2.repos
BUILD args: --packages-above-and-dependencies common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msg sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry point_cloud_transport point_cloud_transport_py interactive_markers
TEST args: --packages-above common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msg sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry point_cloud_transport point_cloud_transport_py interactive_markers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20473

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Sep 17, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
clalancette
clalancette approved these changes Oct 5, 2026
View reviewed changes

@clalancette clalancette left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it also looks like CI failed.

@ahcorde

ahcorde commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: ros2/common_interfaces#342, ros/ros_tutorials#206, #235, ros/pluginlib#310, ros/robot_state_publisher#255, ros/resource_retriever#127, ros-perception/laser_geometry#121, ros-perception/point_cloud_transport#194, ros-visualization/interactive_markers#119
Gist: https://gist.githubusercontent.com/ahcorde/b793b620dd0d947cf1dae657fc4c3df4/raw/7da9b14f75fd37e2ba8ed44f760e3a630c930385/ros2.repos
BUILD args: --packages-above-and-dependencies common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msgs sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry point_cloud_transport point_cloud_transport_py interactive_markers
TEST args: --packages-above common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msgs sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry point_cloud_transport point_cloud_transport_py interactive_markers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20659

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Oct 5, 2026
Merged
@ahcorde

ahcorde commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: ros2/common_interfaces#342, ros/ros_tutorials#206, #235, ros/pluginlib#310, ros/robot_state_publisher#255, ros/resource_retriever#127, ros-perception/laser_geometry#121, ros-perception/point_cloud_transport#194, ros-visualization/interactive_markers#129
Gist: https://gist.githubusercontent.com/ahcorde/224e2970aeac352b232b27acf2a3cf35/raw/54aa40171dcdd29fd09d3f757086921a6ec9a175/ros2.repos
BUILD args: --packages-above-and-dependencies common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msgs sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry point_cloud_transport point_cloud_transport_py interactive_markers
TEST args: --packages-above common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msgs sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry point_cloud_transport point_cloud_transport_py interactive_markers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20660

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde

ahcorde commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: ros2/common_interfaces#342, ros/ros_tutorials#206, #235, ros/pluginlib#310, ros/robot_state_publisher#255, ros/resource_retriever#127, ros-perception/laser_geometry#121, ros-visualization/interactive_markers#129
Gist: https://gist.githubusercontent.com/ahcorde/9105b4e33a2d59b281254556f309db4e/raw/2a972ae3806fcf8dc4bdb847ef9fbe1d3fb29ec3/ros2.repos
BUILD args: --packages-above-and-dependencies common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msgs sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry interactive_markers
TEST args: --packages-above common_interfaces diagnostic_msgs geometry_msgs nav_msgs sensor_msgs sensor_msgs_py shape_msgs std_msgs std_srvs stereo_msgs trajectory_msgs visualization_msgs turtlesim turtlesim_msgs class_loader pluginlib ros2plugin robot_state_publisher resource_retriever laser_geometry interactive_markers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20661

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
ahcorde merged commit 7ca3a02 into rolling Oct 6, 2026
4 checks passed
@ahcorde
ahcorde deleted the ahcorde/rolling/missing_dependency branch October 6, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes
+1 more reviewer
@fujitatomoya fujitatomoya fujitatomoya approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @clalancette @fujitatomoya