Repository navigation
compare C-string fields as C strings in find/count_items_with_string - #7903
Open
Goober5000 wants to merge 1 commit into
Open
Goober5000 wants to merge 1 commit into
Goober5000 wants to merge 1 commit into
Conversation
Goober5000
added
cleanup
A char array field could not match the FIELD_T* member-pointer overloads, so it fell through to the SCP_string overload, which built a temporary SCP_string for the search string and for every item compared. Dispatch on the field's value instead: item_string_equal overloads compare C-string and char array fields with stricmp and SCP_string fields with lcase_equal, without allocating. This merges the twelve templates into four. Add unit tests covering char*, char[N], and SCP_string fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Goober5000
force-pushed
the
fix/string_utilities
branch
from
October 18, 2026 08:12
63e6115 to
d548d7c
Compare
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A char array field could not match the FIELD_T* member-pointer overloads, so it fell through to the SCP_string overload, which built a temporary SCP_string for the search string and for every item compared. Dispatch on the field's value instead: item_string_equal overloads compare C-string and char array fields with stricmp and SCP_string fields with lcase_equal, without allocating. This merges the twelve templates into four.
Add unit tests covering char*, char[N], and SCP_string fields.