Skip to content

improvement(ui): reuse compact buttons for message actions - #8087

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-icon-button-sizingfrom
codex/control-fix-message-action-buttons
Sep 21, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-icon-button-sizingfrom
codex/control-fix-message-action-buttons

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing compact Button treatment for Copy, Like, Dislike and Fork message actions.
  • Keep command handlers, accessible names, tooltips and pending guards. Normalize the 26px footprint to the existing fixed 24px size and shared corners/hover treatment.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN suite and relevant existing consumer tests pass.
  • Isolated browser fixtures cover light/dark, narrow layouts and the affected controls; picker checks cover keyboard selection, search, editable overlays, multiple selection, modal Escape and focus restoration.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 1:44am UTC

Request Review

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues.

Summary

This PR standardizes Copy, Like, Dislike, and Fork message actions on the shared compact EMCN Button treatment.

  • Replaces custom 26px native buttons with the shared 24px compact fixed-size variant.
  • Preserves accessible labels, tooltips, handlers, and the pending-disabled fork guard.
  • Updates the focused test mock to support the shared Button component.

Reviews (2) · Last reviewed commit: "improvement(ui): reuse compact buttons f..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 0be585b into codex/control-fix-icon-button-sizing Sep 21, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-message-action-buttons branch September 21, 2026 03:32
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 22, 2026
Co-authored-by: Bill Leoutsakos <billleoutsakos@Mac.localdomain>

This branch was previously deployed

1 inactive deployment
Preview 53d13dc0 Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants