Skip to content

improvement(ui): reuse compact buttons for message actions #8087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Sep 21, 2026
Merged

improvement(ui): reuse compact buttons for message actions #8087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* @vitest-environment jsdom
*/
import { act, type ReactNode } from 'react'
import { act, type ComponentProps, type ReactNode } from 'react'
import { createRoot, type Root } from 'react-dom/client'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'

Expand All @@ -19,6 +19,11 @@ vi.mock('next/navigation', () => ({
}))

vi.mock('@sim/emcn', () => ({
Button: ({
variant,
iconSize,
...props
}: ComponentProps<'button'> & { variant?: string; iconSize?: string }) => <button {...props} />,
Comment thread
BillLeoutsakosvl346 marked this conversation as resolved.
Check: () => null,
Duplicate: () => null,
Split: () => null,
Expand Down
31 changes: 17 additions & 14 deletions apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import { memo, useEffect, useRef, useState } from 'react'
import {
Button,
Check,
ChipModal,
ChipModalBody,
Expand All @@ -27,8 +28,6 @@ import { useForkMothershipChat } from '@/hooks/queries/mothership-chats'
import { useFolderStore } from '@/stores/folders/store'

const ICON_CLASS = 'size-[14px]'
const BUTTON_CLASS =
'flex size-[26px] items-center justify-center rounded-[6px] text-[var(--text-icon)] transition-colors hover-hover:bg-[var(--surface-hover)] focus-visible:outline-hidden'

interface MessageActionsProps {
content: string
Expand Down Expand Up @@ -162,14 +161,15 @@ export const MessageActions = memo(function MessageActions({
{canCopyContent && (
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Copy message'
onClick={copyToClipboard}
className={BUTTON_CLASS}
variant='quiet'
iconSize='compact-fixed'
>
{copied ? <Check className={ICON_CLASS} /> : <Duplicate className={ICON_CLASS} />}
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>
{copied ? 'Copied message' : 'Copy message'}
Expand All @@ -180,27 +180,29 @@ export const MessageActions = memo(function MessageActions({
<>
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Like'
onClick={() => handleFeedbackClick('up')}
className={BUTTON_CLASS}
variant='quiet'
iconSize='compact-fixed'
>
<ThumbsUp className={ICON_CLASS} />
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>Good response</Tooltip.Content>
</Tooltip.Root>
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Dislike'
onClick={() => handleFeedbackClick('down')}
className={BUTTON_CLASS}
variant='quiet'
iconSize='compact-fixed'
>
<ThumbsDown className={ICON_CLASS} />
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>Bad response</Tooltip.Content>
</Tooltip.Root>
Expand All @@ -209,15 +211,16 @@ export const MessageActions = memo(function MessageActions({
{canFork && (
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Fork in new chat'
onClick={handleFork}
disabled={forkChat.isPending}
className={cn(BUTTON_CLASS, forkChat.isPending && 'cursor-not-allowed opacity-50')}
variant='quiet'
iconSize='compact-fixed'
>
<Split className={cn(ICON_CLASS, 'rotate-90')} />
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>Fork in new chat</Tooltip.Content>
</Tooltip.Root>
Expand Down
Loading