You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preserve the existing outlined workflow summary chips in light and dark mode.
Move their surface, text, inset outline, height, and padding into a named EMCN ChipTag recipe.
Keep the workflow renderer's width cap, baseline alignment, and muted placeholder styling local to InlineChip.
The earlier gray-variant version changed the fill and ink. The revised implementation renders the original treatment exactly, including in the landing hero where the shared renderer is also used. The review comment contains matched before/after images and source examples.
Verification
Actual component fixtures with product CSS and Season font: computed chip geometry and appearance matched staging in light and dark at 16px and 20px root sizes, for filled, placeholder, and truncated values.
Workflow renderer: 144 tests passed; EMCN and workflow renderer type checks passed; changed-file Biome passed.
The local design diff checker reports six expected EMCN central-definition review signals for the new variant, with no consumer violations or coverage failures.
Immutable full scans of current staging and a temporary staging-plus-PR comparison commit: 1,138 → 1,134 findings. Exactly four InlineChip caller background/shadow findings disappear, with zero new finding IDs. Advisory items stay at 333, unchecked diagnostics at 1,955, and coverage failures at zero. The existing muted-placeholder text override remains visible for later design review.
GitHub CI passed on the current head. The desktop Electron smoke job first hit an unrelated teardown timeout; it passed on the failed-job rerun.
The local EMCN suite passed 348/349 tests; one unrelated modal Escape test fails in this checkout. App type check is blocked by an unrelated local uploaded TypeScript fixture under apps/sim/uploads.
[Medium risk] Refactors chip styling for workflow inline display.
The PR appears safe to merge, with no outstanding correctness or repository-rule violations.
Summary
This PR centralizes the established outlined workflow-summary chip treatment in a named EMCN ChipTag recipe while retaining renderer-specific layout and placeholder behavior in InlineChip.
Adds the workflow-inline EMCN variant with the existing surface, text, inset outline, height, and padding.
Updates InlineChip to consume the shared variant while keeping its width cap, baseline alignment, and muted state local.
The previous concern about retaining bespoke styling is no longer applicable because the clarified design requirement explicitly calls for preserving that outlined appearance.
The first version of this PR made the chips look filled and muted. This revision keeps the original outlined appearance and moves that exact recipe into EMCN. InlineChip still handles the local 160px cap, baseline alignment, and placeholder state. The shared renderer is used by the editor, read-only preview, and landing hero, so the visual treatment stays consistent across them.
Matched images. Each image shows staging on the left and the revised PR on the right, with the actual InlineChip and ChipTag components, compiled product CSS, and Season font. Filled values, muted placeholders, and a truncated long value are shown in both themes. These are isolated component renders, not authenticated workflow screenshots. The computed background, text colour, outline, border, dimensions, padding, radius, and font match for all examples in both themes at both root sizes.
Root size
Before / After in light and dark
16px
20px
The outline uses --border-1, and the fill and text use --surface-2 and --text-primary from globals.css; the variant keeps the geometry in EMCN. No landing source file changes in this PR.
Design clarification for the current head: the gray filled chip was explicitly rejected after visual review. The intended result is the original outlined workflow-summary chip, with its exact recipe owned by EMCN instead of an InlineChip caller override. The updated PR body and visual comment show staging versus current head in light/dark at 16px and 20px; computed fill, ink, outline, dimensions, spacing, and font match. The earlier description advocating gray is superseded. @greptileai please review this PR against that intended appearance and the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChipTagrecipe.InlineChip.The earlier gray-variant version changed the fill and ink. The revised implementation renders the original treatment exactly, including in the landing hero where the shared renderer is also used. The review comment contains matched before/after images and source examples.
Verification
InlineChipcaller background/shadow findings disappear, with zero new finding IDs. Advisory items stay at 333, unchecked diagnostics at 1,955, and coverage failures at zero. The existing muted-placeholder text override remains visible for later design review.apps/sim/uploads.Type of Change
Checklist