Skip to content

refactor(emcn): preserve outlined workflow inline chips #8121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BillLeoutsakosvl346 wants to merge 2 commits into
base: staging
Choose a base branch
from
+7 −2
Open

refactor(emcn): preserve outlined workflow inline chips #8121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5616934
improvement(ui): use shared bordered workflow chips
Sep 21, 2026
75f41f4
refactor(emcn): preserve outlined workflow inline chips
Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/emcn/src/components/chip-tag/chip-tag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ import { cn } from '../../lib/cn'
* when it sits *on* a `--surface-5` input, combobox trigger, or tag container.
* - `gray` — a light surface over a slightly darker inset ring with muted
* `--text-secondary` text for low-emphasis status labels.
* - `workflow-inline` — an outlined slot embedded in workflow summary text.
* Its inset ring preserves the text flow and dimensions when a placeholder
* becomes a value. The surface and outline follow the workspace theme.
* - `solid` — a filled inverse tag: a dark neutral surface (`--text-secondary`)
* with inverse text (`--text-inverse`), mirroring {@link Chip}'s `primary`
* inverse-surface convention one step softer than near-black. For eyebrow
Expand Down Expand Up @@ -70,6 +73,8 @@ const chipTagVariants = cva(
field:
'h-5 gap-[3px] px-1 bg-[var(--surface-6)] text-[var(--text-primary)] dark:bg-[var(--surface-3)]',
gray: 'h-5 gap-[3px] px-1 border border-[var(--border-1)] bg-[var(--surface-5)] text-[var(--text-secondary)]',
'workflow-inline':
'h-5 gap-[3px] px-1 bg-[var(--surface-2)] text-[var(--text-primary)] shadow-[inset_0_0_0_1px_var(--border-1)]',
Comment thread
BillLeoutsakosvl346 marked this conversation as resolved.
solid: 'h-5 gap-[3px] px-1 bg-[var(--text-secondary)] text-[var(--text-inverse)]',
workflow: 'h-5 gap-[3px] px-1',
brand: 'h-5 gap-[3px] px-1',
Expand Down
4 changes: 2 additions & 2 deletions packages/workflow-renderer/src/workflow-block/inline-chip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ export interface InlineChipProps {
export function InlineChip({ children, muted }: InlineChipProps) {
return (
<ChipTag
variant='mono'
variant='workflow-inline'
className={cn(
'inline-flex max-w-[160px] translate-y-[-1px] bg-[var(--surface-2)] align-middle shadow-[inset_0_0_0_1px_var(--border-1)] dark:bg-[var(--surface-2)]',
'max-w-[160px] translate-y-[-1px] align-middle',
muted && 'text-[var(--text-muted)]'
)}
>
Expand Down
Loading