fix(slack-search): stop recovered tool failures from flagging the whole reply

[TheodoreSpeaks]

Summary

• Slack timeline mode collapses the whole task group under "Something went wrong" if any single task reports error
• The agent routinely recovers from an individual failed search_workspace / read_document call and retries, so one rejected call was flagging otherwise successful answers
• Finished tool calls now always report complete; error is reserved for tasks interrupted by a real Assistant failure (unchanged)

Type of Change

• Bug fix

Testing

Updated assistant-stream tests; lint + audits pass

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01CB5jCGYioyw1ddnx58wbbM

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 26, 2026 7:44pm UTC

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Changes how tool failures are reported in chat responses.

The PR appears safe to merge; no outstanding finding remains.

Summary

The PR makes finished Slack search tool tasks report complete so a recovered tool failure does not mark the whole reply as failed.

• The updated test covers a failed call followed by a successful retry and a completed answer.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Tool call] --> B[Task in progress]
  B --> C[Tool result]
  C --> D[Task complete]
  D --> E[Assistant continues and finishes reply]

Loading

_{Reviews (3) · Last reviewed commit: "test(slack-search): cover reply completi..."}

[TheodoreSpeaks]

@greptile

[TheodoreSpeaks]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[TheodoreSpeaks]

@greptile

[TheodoreSpeaks]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}