Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset::exists()andAsset::metaExists()answered viacontainer()->files(), which unserializes the whole cached recursive listing.Asset::find()calls both, so resolving one asset reference on the front end loaded the full listing. On a 197k-file S3 container that is an 80 MB cache entry and OOMs a 1 GB worker.Both methods now use the in-memory listing only when this request has already loaded it (
AssetContainerContents::isLoaded()), and otherwise do a singledisk()->exists()call (one S3HEAD). CP listings load the listing first, so they keep their zero-extra-IO behaviour.I skipped the suggested meta-cache shortcut:
move()never forgets the old path's meta key, so it would report a moved-away path as existing. A disk check is always right.Some tests asserted the raw cached listing keys and relied on
exists()loading the listing before the.metafile was written. The listing now loads afterwards, so those expectations include the.metaentries, which the listing already filters out on read.Closes #15607