Repository navigation
Conversation
Contributor
|
Love this, should make a big difference on our bigger sites too. Thanks Erin! |
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

AssetContainerContents::all()caches the raw recursive listing,.meta/*.yamlincluded. Withcache_metaon that's one meta file per asset, so roughly half the cached payload is entries nothing reads through the listing. On one site that's 197k entries, an 80 MB serialized key, and an OOM on load.The listing now rejects
.metapaths (files and the.metadirectories themselves) before caching.metaFilesIn()lists<folder>/.meta(or<folder>recursively) from the filesystem on demand instead of filtering the cache, andAsset::metaExists()checks the disk directly since the listing no longer knows about meta.Tradeoffs:
metaFiles()at the root recursively is now a full uncached disk walk perAssetContainerContentsinstance (onlyassets:meta:cleancalls it today), andmetaExists()is one diskexists()persyncOriginal()even when the CP already has the listing loaded. Left the.metarejects infilteredFilesIn()/filteredDirectoriesIn()so an already-warm pre-upgrade cache still behaves.#15609 is stacked on this and should merge after it.
Closes #15608