Repository navigation
[6.x] Show a loading state while the icon and template fieldtypes fetch their options - #15633
Open
duncanmcclean wants to merge 1 commit into
Open
duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a loading state to the Icon and Template fieldtypes.
Both fieldtypes fetch their options over AJAX before rendering the
Combobox, and rendered nothing at all while the request was in flight. On the collection configure page, the icon field sits near the top of the form, so when the icons request is slow (we've seen it take ~10 seconds on one site) the field just looks empty.This PR fixes it by rendering a small spinner with "Loading" text while the request is pending. The loading row is the same height as the combobox (and the compact mode's button), so there's no layout shift when the options arrive.
CleanShot.2026-10-12.at.13.08.03.mp4