Skip to content

[6.x] Show a loading state while the icon and template fieldtypes fetch their options #15633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 1 commit into from
Oct 16, 2026
Merged

[6.x] Show a loading state while the icon and template fieldtypes fetch their options #15633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions resources/js/components/fieldtypes/IconFieldtype.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,13 @@ request();
</script>

<template>
<div v-if="loading" class="flex h-10 items-center gap-2 text-sm text-gray-500">
<Icon name="loading" class="size-4" />
{{ __('Loading') }}
</div>

<Combobox
v-if="!loading && !isCompact"
v-else-if="!isCompact"
clearable
:disabled="config.disabled"
:model-value="value"
Expand Down Expand Up @@ -135,7 +140,7 @@ request();
</template>
</Combobox>

<div v-else-if="!loading" class="flex items-center">
<div v-else class="flex items-center">
<Button
icon-only
size="base"
Expand Down
11 changes: 8 additions & 3 deletions resources/js/components/fieldtypes/TemplateFieldtype.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<template>
<div v-if="loading" class="flex h-10 items-center gap-2 text-sm text-gray-500">
<Icon name="loading" class="size-4" />
{{ __('Loading') }}
</div>

<Combobox
v-if="!loading"
v-else
:clearable="config.clearable"
:placeholder="__(config.placeholder)"
:read-only="isReadOnly"
Expand All @@ -21,10 +26,10 @@

<script>
import Fieldtype from './Fieldtype.vue';
import { Combobox } from '@/components/ui';
import { Combobox, Icon } from '@/components/ui';

export default {
components: { Combobox },
components: { Combobox, Icon },
mixins: [Fieldtype],

data: function () {
Expand Down
Loading