checks: simplify, match prod - #2471
Merged
Merged
Conversation
PostgreSQL Extension Dependency Analysis: PR #2471
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
brainrake
marked this pull request as ready for review
September 21, 2026 03:10
PostgreSQL Package Dependency Analysis: PR #2471
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
mmlb
requested changes
Sep 21, 2026
mmlb
left a comment
mmlb
left a comment
Collaborator
There was a problem hiding this comment.
commit message isn't super great would have preferred just the why and not so much the how.
Comment on lines
+368
to
+369
| echo "session_preload_libraries = 'supautils'" | ||
| echo "dynamic_library_path = '${supautils}/lib:\$libdir'" |
Collaborator
There was a problem hiding this comment.
Everything looks great except for this bit which seems like it snuck in? There's no mention of this in the commit message.
Collaborator
Author
There was a problem hiding this comment.
First line is to match production more closely. Prod uses session_preload_libraries for supautils, while this test used shared_preload_libraries.
Second line is needed because supautils is also removed from WANTED_EXTS (to not end up in shared_preload_libraries) so it is not in $libdir.
Collaborator
Author
There was a problem hiding this comment.
It was mentioned in the PR description. Sorry about the commit slop, forgot to review that. Fixed.
Collaborator
There was a problem hiding this comment.
ah, my eyes definitely crossed when looking at the old description :D
…ectly supautils now loads via session_preload_libraries to match production. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
brainrake
force-pushed
the
checks-simplify-legacy-pkgname
branch
from
September 21, 2026 15:21
680b1ec to
f57e7c9
Compare
brainrake
changed the title
mmlb
approved these changes
Sep 22, 2026
mmlb
left a comment
mmlb
left a comment
Collaborator
There was a problem hiding this comment.
lgtm nice simplification and making things look like prod is the way to be!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
legacyPkgVersion, reusepgpkg.versionsession_preload_librariesinstead ofshared_preload_libraries)