chore: forward bitkit-docker's new lnd and lnurl host ports in just run docker

[ovitrif]

Refs: synonymdev/bitkit-docker#19

Description

• just run docker forwards 23735 (LND P2P) and 23000 (LNURL server) through adb reverse, the host ports bitkit-docker#19 moves them to. LND advertises 127.0.0.1:23735 in its node URI, so a channel open from the emulator dials that port.

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

N/A

Manual Tests

• just run docker against bitkit-docker main after Popup for new transactions #19 → adb reverse --list shows tcp:23735 and tcp:23000.

Automated Checks

N/A

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-07T23:46:14.225466Z	6c21807	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

Regtest APK

Built from 6c21807 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Changes local development port forwarding for Docker setup.

The PR appears safe to merge; no actionable defects were found in the two port changes.

Summary

Updates just run docker to forward LND on port 23735 and the LNURL server on port 23000, matching the companion Docker update described in the PR.

• Both forwards still use the selected Android device.
• No actionable issues were found.
• Device connections were not tested. The companion Docker changes could not be read because GitHub access required authentication.

_{Reviews (1) · Last reviewed commit: "chore: forward bitkit-docker's lnd p2p a..." · Reviewed by Greptile}

[talosmachina]

No findings. Moves just run docker's adb reverse forwards to bitkit-docker's new host ports for LND P2P (23735) and the LNURL server (23000). Reviewed 6c21807, light tier.

What I checked, and 2 candidates I ruled out

Read in full: Justfile (run recipe)
Cross-repo contract: bitkit-docker#19 (merged) publishes LND as 23735:9735 with --externalip=127.0.0.1:23735, and lnurl-server as 23000:3000 with DOMAIN=http://localhost:23000, so the node URI and the LNURL callbacks the emulator receives both name the forwarded ports.
CI: green (build, lint, detekt); e2e jobs skipped by change detection.
Not built here: Bitkit Android branches are reasoned from code and CI, not built on this box.

Ruled out

• Other callers still on 9735/3000: no other reference in the repo targets the local docker LND or lnurl-server by those ports. The remaining 127.0.0.1:9735 strings are preview and mock data (IcJitEntry.kt, TransferPreviewData.kt, PeerDetailsTest.kt).
• Emulator reaching other bitkit-docker services: the E2E build dials them at E2E_LOCAL_HOST (default 10.0.2.2), not through adb reverse, so they need no forward.

Merge confidence: 5/5, CI green and the change is a config value no test would exercise.

[jvsena42]

No findings at 6c21807.

Checked:

• Justfile:117-118: both adb reverse tcp:<port> tcp:<port> lines are valid and use the same port on each side, so host/device order cannot be wrong.
• 23735 and 23000 match what the fixture advertises after synonymdev/bitkit-docker#19 (--externalip=127.0.0.1:23735, DOMAIN=http://localhost:23000). The app has no hardcoded local LND or lnurl-server address; it dials what the fixture hands out, which is device loopback and is what adb reverse covers.
• Services the E2E build dials by fixed number go through E2E_LOCAL_HOST and were not moved by that change: Electrum 60001, Homegate 6288, Trezor Bridge 21325.
• No other consumer of the old 9735 / 3000 host ports at head: remaining hits are staging peers, preview data, a placeholder, animation durations and tests. journeys/README.md describes just run docker without port numbers.

Not run on a device. Device gate: no device check needed (dev tooling only, no user-visible change).

[jvsena42]

No findings at 6c21807.

Checked:

• Justfile:117-118: both adb reverse tcp:<port> tcp:<port> lines are valid and use the same port on each side, so host/device order cannot be wrong.
• 23735 and 23000 match what the fixture advertises after synonymdev/bitkit-docker#19 (--externalip=127.0.0.1:23735, DOMAIN=http://localhost:23000). The app has no hardcoded local LND or lnurl-server address; it dials what the fixture hands out, which is device loopback and is what adb reverse covers.
• Services the E2E build dials by fixed number go through E2E_LOCAL_HOST and were not moved by that change: Electrum 60001, Homegate 6288, Trezor Bridge 21325.
• No other consumer of the old 9735 / 3000 host ports at head: remaining hits are staging peers, preview data, a placeholder, animation durations and tests. journeys/README.md describes just run docker without port numbers.

Not run on a device. Device gate: no device check needed (dev tooling only, no user-visible change).