Repository navigation
Return public engagements when private inclusion is unauthorized - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When callers without private-list access send
includePrivate=true, the engagement list returns HTTP 401 and breaks the opportunities page. This change silently disables the flag and returns the normal public results, preserving pagination, filters, and public-field redaction.Administrator/Talent Manager/M2M access, member-scoped
appliedByMeaccess, and explicitON_HOLDauthorization remain unchanged. API documentation and authorization regression tests cover the fallback.Validation:
pnpm lintandpnpm buildpass.includePrivate AccessHTTP suite: 12 tests pass.448c6d7with the same isolated test setup: five stale detail-read expectations and two outdated application-create routes.Companion UI role alignment: topcoder-platform/platform-ui#2483