Repository navigation
Cover private engagement permission edge cases -> dev - #2483
Merged
Merged
Conversation
jmgasper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket
Not provided.
What's in this PR?
Add regression coverage for two private-engagement role edge cases: an uppercase Administrator role with surrounding whitespace retains private-list access, while Group Administrator loads public opportunities without requesting private access.
The implementation is already on
devthrough #2482. This branch incorporates the latestdevand retains its permission checks, documentation, mixed-role coverage, and public-opportunity rendering assertions.Companion API fallback: topcoder-platform/engagements-api-v6#71
Validation:
yarn lint,yarn run build, and all 17 engagement-list regression tests pass.