Conversation
Summary: Intent: - Establish durable queue state shared by time-based logical admission policies. Changes: - Add the build admission deadline to the Queue entity and MySQL backend. - Cover optimistic storage updates and deadline round-tripping.
This was referenced Sep 15, 2026
mnoah1
marked this pull request as ready for review
September 15, 2026 17:21
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 15, 2026 17:21
mnoah1
added this pull request to stack #712
September 15, 2026 20:54
mnoah1
removed this pull request from stack #712
September 15, 2026 21:02
mnoah1
added this pull request to stack #715
September 15, 2026 21:03
mnoah1
commented
Sep 15, 2026
| latest_request_id VARCHAR(255) NOT NULL DEFAULT '', | ||
| version INT NOT NULL, | ||
| last_green_request_id VARCHAR(255) NOT NULL DEFAULT '', | ||
| build_admission_not_before_ms BIGINT NOT NULL DEFAULT 0, |
Contributor
Author
There was a problem hiding this comment.
Need a default during the initial migration (cannot have NOT NULL without a default value), but can remove later after existing tables are updated. New field must be last in the table.
mnoah1
removed this pull request from stack #715
September 15, 2026 21:20
mnoah1
added this pull request to stack #716
September 15, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Add a way to support time-based throttling of new builds on a queue. This can be used to support two main scenarios where we might not want to immediately start the next build as soon as the build slot is free:
Changes: