Conversation
This was referenced Sep 15, 2026
mnoah1
force-pushed
the
mnoah1/stovepipe-admission-throttle
branch
from
September 15, 2026 17:37
fd1f6ce to
fe94134
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-failure-cooldown
branch
from
September 15, 2026 17:37
9d96d6f to
8bff754
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-admission-throttle
branch
from
September 15, 2026 17:51
fe94134 to
6514bbe
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-failure-cooldown
branch
from
September 15, 2026 17:51
8bff754 to
2e13236
Compare
mnoah1
added this pull request to stack #712
September 15, 2026 20:54
mnoah1
force-pushed
the
mnoah1/stovepipe-failure-cooldown
branch
from
September 15, 2026 20:59
2e13236 to
a4407f5
Compare
mnoah1
removed this pull request from stack #712
September 15, 2026 21:02
mnoah1
changed the base branch from
mnoah1/stovepipe-admission-throttle
to
mnoah1/stovepipe-admission-config-v2
September 15, 2026 21:03
mnoah1
added this pull request to stack #715
September 15, 2026 21:03
mnoah1
force-pushed
the
mnoah1/stovepipe-failure-cooldown
branch
from
September 15, 2026 21:10
a4407f5 to
d681ca1
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-admission-config-v2
branch
from
September 15, 2026 21:10
aa3aa8b to
c6cb600
Compare
mnoah1
removed this pull request from stack #715
September 15, 2026 21:20
Summary: Intent: - Avoid immediately consuming more build resources after a runner-reported failure. Changes: - Persist the first terminal observation time on Build. - Advance the admission deadline while releasing the failed build slot in one queue CAS. - Add per-queue failure cooldown configuration to the YAML policy store. - Keep success, cancellation, and DLQ-forced failure outside the cooldown policy. This change builds on the per-queue admission configuration introduced by the parent PR.
mnoah1
force-pushed
the
mnoah1/stovepipe-failure-cooldown
branch
from
September 15, 2026 21:26
d681ca1 to
7d99424
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
This change builds on the per-queue admission configuration introduced by the parent PR.
Test Plan
go test ./stovepipe/... ./service/stovepipe/server./tool/bazel test //stovepipe/... //service/stovepipe/server:go_default_testRevert Plan
Revert this PR to disable failure-specific admission cooldowns while retaining general throttling.
Issues