Repository navigation
Skip validation when accessing storage scalar of extension scalar - #9875
robert3005 wants to merge 2 commits into
Conversation
Merging this PR will degrade performance by 3.38%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | dict_canonicalize_gt_u8_avx2[16000000] |
6.8 ms | 11.5 ms | -40.97% |
| ❌ | WallTime | words_gather_scalar_avx2[65536] |
8.2 µs | 9.3 µs | -11.78% |
| ⚡ | WallTime | dict_canonicalize_gt_u8_neon[1000000] |
561.1 µs | 486.9 µs | +15.22% |
| ⚡ | Simulation | allocate_drop_vortex_minimal_alignment[0] |
1,077.2 ns | 968.9 ns | +11.18% |
| ⚡ | Simulation | allocate_drop_vortex[0] |
1.1 µs | 1 µs | +10.57% |
| ⚡ | Simulation | allocate_drop_bytes[0] |
581.3 ns | 527.2 ns | +10.27% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/storagevalid (a06f918) with develop (022c604)
Footnotes
-
218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
dd50732 to
1553c58
Compare
Signed-off-by: Robert Kruszewski <github@robertk.io>
1553c58 to
a06f918
Compare
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
This was already validated and current implementation panics