Repository navigation
fix: preserve Unicode pairs during browser deletion - #1094
Merged
Merged
Conversation
andiwand
force-pushed
the
review/75-document-resources
branch
from
October 5, 2026 19:50
4eb1b52 to
c6d4da9
Compare
A local step helper keeps the deletion ranges within the line length the rest of document.js uses. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/76-editor-unicode-deletion
branch
from
October 5, 2026 20:04
e832c5a to
2401787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Fallback Backspace/Delete now advance over a whole Unicode code point instead of one UTF-16 unit. A shared helper serves document and plain-text editors, including formatted-run boundaries; undo continues counting stored UTF-16 units.
Validation: all 735 browser checks pass across 20 pages with an isolated headless browser and an explicit viewport. The new document deletion cases fail on the parent scripts. Earlier annotation failures came from the runner opening a 1×1 viewport; no production annotation change was needed.