improvement(ui): share workflow preview actions by BillLeoutsakosvl346 · Pull Request #8065 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-20T22:47:39Z

Summary

Share the three embedded workflow preview actions through one product component using EMCN Button and Tooltip.
Preserve the 24px geometry, solid surface, accessible labels, icons and open/expand handlers.

Type of Change

Refactor / maintainability improvement

Testing

Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
External source comparison confirms caller logic and content are unchanged.
Original and extracted components have matching computed styles in light/dark browser fixtures; keyboard, disabled and expansion behavior checked. These are isolated fixtures, not full authenticated product flows.
Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-20T22:47:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 24, 2026 10:11pm UTC

cubic-dev-ai

No issues found across 4 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-20T22:50:17Z

Confidence Score: 5/5

The PR appears safe to merge because the refactor preserves the existing preview-action behavior and no actionable regressions remain.

Summary

This PR extracts the repeated embedded-workflow preview action into a shared WorkflowPreviewAction component.

Preserves the existing open and expand handlers at all three call sites.
Centralizes the tooltip, accessible label, fixed button behavior, positioning, and visual treatment.
The previously reported props-interface and fixed-button-type concerns are resolved; the transition concern was correctly conceded because the underlying EMCN Button already supplies it.

_{Reviews (5) · Last reviewed commit: "improvement(ui): share workflow preview ..."}

BillLeoutsakosvl346 · 2026-09-20T22:56:51Z

@greptile

BillLeoutsakosvl346 · 2026-09-20T22:56:52Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-20T22:56:57Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 4 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T17:57:19Z

Before / after visual comparison

Workflow preview open/expand actions share WorkflowPreviewAction while retaining their existing small bordered button treatment.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: b779967927.

BillLeoutsakosvl346 · 2026-09-22T20:00:09Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T20:00:10Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T20:00:18Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 4 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T20:13:34Z

@greptile Please re-review the current head. The inline response explains the shared definition and the authorized design-system scope.

BillLeoutsakosvl346 · 2026-09-22T20:28:35Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T20:28:36Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T20:28:40Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 4 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

* Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* improvement(emcn): share ordinary action geometry in Button * improvement(ui): share additional-field disclosures * fix(ui): preserve tiny actions and use shared sidebar geometry * improvement(ui): use shared geometry for standard icon actions (#8153) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): centralize overlay action buttons in EMCN (#7990) * refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): reuse shared button and focus treatments (#8187) * improvement(ui): reuse shared button and focus treatments * fix(emcn): include outline reset in muted focus ring * fix(ui): make closed table sidebars inert and strengthen focus ring * Carry code search overlay into the live EMCN stack (#8275) * refactor(ui): share code search overlay controls * refactor(emcn): own compact code search field chrome * test(ui): cover floating compact code search * refactor(emcn): compose compact search from shared chip surface --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): announce code search result changes * docs(ui): describe shared table sidebar exports --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>

vercel Bot temporarily deployed to Preview September 20, 2026 22:47 Inactive

cubic-dev-ai Bot reviewed Sep 20, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 20, 2026

View reviewed changes

Comment thread apps/sim/components/workflow/workflow-preview-action.tsx Outdated

Comment thread apps/sim/components/workflow/workflow-preview-action.tsx Outdated

vercel Bot temporarily deployed to Preview September 20, 2026 22:56 Inactive

cubic-dev-ai Bot reviewed Sep 20, 2026

View reviewed changes

BillLeoutsakosvl346 force-pushed the codex/control-fix-field-disclosures branch from 2d56098 to f472cbb Compare September 22, 2026 19:57

BillLeoutsakosvl346 changed the base branch from codex/control-fix-field-disclosures to codex/control-fix-overlay-action-buttons September 22, 2026 20:00

BillLeoutsakosvl346 force-pushed the codex/control-fix-workflow-preview-actions branch from b779967 to 34cc3c8 Compare September 22, 2026 20:00

vercel Bot temporarily deployed to Preview September 22, 2026 20:00 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread apps/sim/components/workflow/workflow-preview-action.tsx Outdated

improvement(ui): share workflow preview actions

3e6c870

BillLeoutsakosvl346 force-pushed the codex/control-fix-overlay-action-buttons branch from e5c205a to 9c2953d Compare September 22, 2026 20:28

BillLeoutsakosvl346 force-pushed the codex/control-fix-workflow-preview-actions branch from 34cc3c8 to 3e6c870 Compare September 22, 2026 20:28

vercel Bot temporarily deployed to Preview September 22, 2026 20:28 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

improvement(ui): reuse inline and overlay workflow actions

08b4f43

improvement(ui): reuse inline and overlay workflow actions

319f8bb

vercel Bot temporarily deployed to Preview September 23, 2026 02:24 Inactive

This was referenced Sep 24, 2026

refactor(emcn): share Code.Viewer appearances #8238

Merged

Share table sidebar shell and scroll body #8249

Merged

Keep workflow preview values readable #8256

Merged

BillLeoutsakosvl346 and others added 2 commits September 24, 2026 15:09

refactor(emcn): share Code.Viewer appearances (#8238)

9d5746a

* Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

Share table sidebar shell and scroll body (#8249)

5ca5a29

* Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

vercel Bot temporarily deployed to Preview September 24, 2026 22:10 Inactive

Keep workflow preview values readable (#8256)

c108046

* fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

vercel Bot temporarily deployed to Preview September 24, 2026 22:10 Inactive

BillLeoutsakosvl346 merged commit 3a9630e into codex/control-fix-overlay-action-buttons Sep 24, 2026
6 checks passed

waleedlatif1 deleted the codex/control-fix-workflow-preview-actions branch September 24, 2026 23:58

Conversation

BillLeoutsakosvl346 commented Sep 20, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 20, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Before / after visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Sep 20, 2026 •

edited

Loading

greptile-apps Bot commented Sep 20, 2026 •

edited

Loading